updates to deploy-dev.yml to save all workflow artifacts including do… #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - name: Upload Docker Build Artifact | ||
| if: ${{ steps.image_check.outputs.docker_inspect == 1 }} | ||
| uses: actions/upload-artifact@v3 | ||
| with: |
There was a problem hiding this comment.
Is the goal here to provide access to the docker image after it's been built? If so we are pushing our images once they're built to https://github.com/CDCgov/ReportVision/pkgs/container/reportvision-ocr-api and we are doing this at .github/actions/build-publish-api. Once that image is published to the GH registry, the azure/webapps-deploy@v3 action uses it here:
There was a problem hiding this comment.
Something we could possibly think of doing is migrating our registry to something like ACR instead. The main con however to doing that would be if this system ever needs to be cloud agnostic in the future, which it most likely would need to be.
|
Deprioritized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ckerbuild
Description
[Provide a brief description of the changes implemented in this pull request.]
Screenshots (if applicable)
Related Issues
[Link any related issues or tasks from your project management system.]
Checklist